Fix image pattern for FedoraSecondary provider on s390x #6082
+74
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6082 +/- ##
===========================================
+ Coverage 54.32% 68.66% +14.33%
===========================================
Files 202 202
Lines 21892 21899 +7
===========================================
+ Hits 11892 15036 +3144
+ Misses 10000 6863 -3137 ☔ View full report in Codecov by Sentry. |
harvey0100
force-pushed
the
vmimage
branch
2 times, most recently
from
792b6f2 to
d0fabf4
Compare
clebergnu
requested changes
Dec 11, 2024
There was a problem hiding this comment.
Hi @harvey0100, this does seem to address the issue at hand, but I spotted a few blockers. Thanks for working on this!
harvey0100
force-pushed
the
vmimage
branch
8 times, most recently
from
3aff299 to
f5209e7
Compare
Updated the image pattern in FedoraSecondaryImageProvider to match the available Fedora image file names for the s390x architecture. This resolves the issue where the vmimage utility could not download the correct image due to a pattern mismatch. Reference: avocado-framework#6071 Signed-off-by: Harvey Lynden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the image pattern in FedoraSecondaryImageProvider to match the available Fedora image file names for the s390x architecture. This resolves the issue where the vmimage utility could not download the correct image due to a pattern mismatch.
Reference: #6071